The accounting will be easy and most likely insignificant to the decision.

Congratulations on your investing decision.

Had a VERY poor layout from a couple additions over the years so it was fairly unappealing in more ways than one. 

Do not make any emotional decisions. 

I grew up from poor beginnings and without any kind of travel opportunity, so I am ultimately working toward financial freedom so that my son and I are able to travel.

I don't have anything to add to your decision, but I plan to read the book that @Mark Welp suggested and follow this thread.

IE simply searching out the data that justifies their decision/conclusion.

If this is an attorney that handles a lot of your brothers business already he might not be able to be impartial.This is a big decision so at a minimum you might want another attorney do a review of the agreement with you on a phone call.Just because family is involved do not assume everything will be fair etc.No legal advice given. 

I have two questions for the community- 1-Do you have any general advice related to purchasing a condo versus rental related to making smart financial decisions?

The husband has very good credit of 706, no late payments and is the primary breadwinner; his wife is a SAHM, has poor credit of 594, mostly due to late payments (some 120 days late) of student loans, some as recently as April 2018.