I would prioritize finding an accountant who specializes in real estate taxation over one that is local.There are 20+ accountants on this message board who specialize in real estate taxation.

This is probably a CPA/Tax professional question - which form of business entity should I pursue to minimize taxation for foreign investors and for myself? 

There are about 20 accountants on this message board who specialize in real estate taxation.

If an IRA has an equity stake in such a business and does so on a regular or repeated basis, then an IRA is subject to taxation on Unrelated Business Taxable Income (UBTI), which is designed to level the playing field and protect tax-paying businesses from unfair competition.As such, for an IRA to participate in such deals, it is best to do so as a lender. 

You acquired real estate that is both a personal residence and an investment property.As such, some items such as property taxes, depreciation, mortgage interest need to be allocated appropriately.There are a couple of accountants in the NYC area that specialize in real estate taxation that would be able to handle your issue.Good luck on the search.

From a taxation standpoint, wouldn't one WANT the profits from self storage investing to be treated passively rather than as earned income? 

@Michael BishopHave you ever taken the cash out proceeds of a syndication and 1031 into another syndication avoiding that large capital gains tax at the end of a syndication where the sponsor sells the property(s)?

I recommend that they setup an LLC and when they expect their net earnings to exceed what a reasonable salary is for agents in their region, then I recommend electing to be taxed as an S-Corp, so that they can set their salary to the reasonable amount and fix their SE tax at that level.

I would put a priority of finding an accountant who specializes in real estate taxation over one that is local.There are 20+ accountants on this message board who specialize in real estate taxation.

Agree with the details above BUT for buy & hold rentals I also look at the operating costs, Capex & esp depreciation recapture (taxation), as that can be a sobering realization on what the 'final' equity is after a future disposition.