Hi @Ryan Kowalewski,
What your advisor is suggesting is a fairly standard structure. As @Michael Plaks mentioned, we would need a lot more information in order to really offer you advice.
In general though, I think it is a fairly good structure. I personally don't like the idea of having real estate that you will be holding long-term in an S-corporation, so I like the suggestion of having it in an LLC. My reason is that there are potential tax consequences to distributing real estate (or any other property) out of an S-corporation, and there can be good business reasons to need to take the real estate out of the business. I think having it in an LLC preserves flexibility.
Whether the operating business itself should be an S-corporation or an LLC depends upon a lot of factors specific to the business and your state's tax laws. A number of states have separate taxes and fees assessed against these entities even though they are pass-through entities taxed at the individual level (except for LLCs taxed as a C-corporation). California, for example, has an $800 LLC Tax and potentially an additional LLC fee based upon your business revenue (not income). For S-corporations, California assesses a tax at the greater of $800 or 1.5 of net income (not revenue).
Also, you need to factor in whether the new tax law changes things for your situation. In the past, a C-corporation could almost be dismissed out of hand because it wouldn't make sense for most situations. With the new tax law creating a flat 21% C-corporation rate (with double taxation still a factor), it is an option that should be discussed. It still does not work for many situations, but if you are expecting good profits but will be reinvesting most of them in the business for a few years it may make sense for you.