I have an STR in Niagara Falls and it does pretty well based on the purchase price. The winter months, it's pretty much empty but the summer months makes up for it. I did get grandfathered in and the area where I bought is in a nice part of town. I've considered areas close to the Falls, but sellers seem to price it a lot higher assuming the buyer can make it up renting it short term. When I purchased my property, I had read all the exciting developments in the works...indoor waterpark, shops, new hotels, restaurants, etc., but was severely disappointed when I went recently with my family. There have definitely been some upgrades in the park itself and there were some new restaurants/hotels and they did try to make the streets nicer. While I didn't like feeling I was in Time Square on the Canadian side of Niagara Falls, the New York side felt completely dead. There was also a large plot of land when it looks like something maybe in underconstruction but stopped....
I really do hope Niagara Falls revitalizes. It has so much potential.